Bug 240309
| Summary: | Remove a first bit of unused plug-in code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> |
| Component: | Plug-ins | Assignee: | Darin Adler <darin> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Darin Adler
We can remove a lot of code. Instead of a plug-in mechanism, we just need enough for the PDF support built into WebKit. This will be a first patch to remove it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yusuke Suzuki
I’m excited about this since it can pave the way to finally removing RuntimeArray JSCell which introduced a lot of weird special code in JSC (RuntimeArray looks like a JSArray, but not a real JSArray, it caused a lot of trouble in DFG optimization etc. so far).
Darin Adler
I’m trying to take it slow; last time I removed too much all at once.
Darin Adler
Seems like legacy WebKit also has a way to make plug-ins using Objective-C and it’s not clear we deprecated that yet.
Radar WebKit Bug Importer
<rdar://problem/93508964>
Darin Adler
Pull request: https://github.com/WebKit/WebKit/pull/752
EWS
Committed r294526 (250781@main): <https://commits.webkit.org/250781@main>
Reviewed commits have been landed. Closing PR #752 and removing active labels.