Bug 240308
| Summary: | git-webkit land should apply the merge-queue label | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=239777 | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Aakash Jain
Currently on pure github checkout, git-webkit land command fails with following error:
[OpenSource]$git-webkit land
Cannot 'land' on a canonical SVN repository that is not configured as git-svn
It should instead apply the merge-queue or unsafe-merge-queue label to the corresponding PR.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
I would expect all git commands to work in pure git checkouts - for people using git-svn, there is always webkit-patch.
Alexey Proskuryakov
*all git-webkit commands
Aakash Jain
This bug is about pure GitHub checkout. On pure GitHub checkout, git-webkit land command currently errors out, it shouldn’t.
Radar WebKit Bug Importer
<rdar://problem/93501363>
Jonathan Bedard
*** Bug 240600 has been marked as a duplicate of this bug. ***
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/1706
EWS
Committed r295761 (251766@main): <https://commits.webkit.org/251766@main>
Reviewed commits have been landed. Closing PR #1706 and removing active labels.
Jonathan Bedard
Re-opening for pull request https://github.com/WebKit/WebKit/pull/1747
EWS
Committed 251805@main (e358612bebec): <https://commits.webkit.org/251805@main>
Reviewed commits have been landed. Closing PR #1747 and removing active labels.