Bug 240308 - git-webkit land should apply the merge-queue label
Summary: git-webkit land should apply the merge-queue label
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
: 240600 (view as bug list)
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-05-11 07:26 PDT by Aakash Jain
Modified: 2022-06-23 15:27 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-05-11 07:26:17 PDT 
Currently on pure github checkout, git-webkit land command fails with following error:

[OpenSource]$git-webkit land
Cannot 'land' on a canonical SVN repository that is not configured as git-svn


It should instead apply the merge-queue or unsafe-merge-queue label to the corresponding PR.
Comment 1 Alexey Proskuryakov 2022-05-17 12:36:39 PDT 
I would expect all git commands to work in pure git checkouts - for people using git-svn, there is always webkit-patch.
Comment 2 Alexey Proskuryakov 2022-05-17 12:36:56 PDT 
*all git-webkit commands
Comment 3 Aakash Jain 2022-05-18 06:31:12 PDT 
This bug is about pure GitHub checkout. On pure GitHub checkout, git-webkit land command currently errors out, it shouldn’t.
Comment 4 Radar WebKit Bug Importer 2022-05-18 07:27:12 PDT 
<rdar://problem/93501363>
Comment 5 Jonathan Bedard 2022-05-18 15:24:21 PDT 
*** Bug 240600 has been marked as a duplicate of this bug. ***
Comment 6 Jonathan Bedard 2022-06-22 16:55:47 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1706
Comment 7 EWS 2022-06-22 18:03:04 PDT 
Committed r295761 (251766@main): <https://commits.webkit.org/251766@main>

Reviewed commits have been landed. Closing PR #1706 and removing active labels.
Comment 8 Jonathan Bedard 2022-06-23 15:20:54 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/1747
Comment 9 EWS 2022-06-23 15:27:29 PDT 
Committed 251805@main (e358612bebec): <https://commits.webkit.org/251805@main>

Reviewed commits have been landed. Closing PR #1747 and removing active labels.