WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
240308
git-webkit land should apply the merge-queue label
https://bugs.webkit.org/show_bug.cgi?id=240308
Summary
git-webkit land should apply the merge-queue label
Aakash Jain
Reported
2022-05-11 07:26:17 PDT
Currently on pure github checkout, git-webkit land command fails with following error: [OpenSource]$git-webkit land Cannot 'land' on a canonical SVN repository that is not configured as git-svn It should instead apply the merge-queue or unsafe-merge-queue label to the corresponding PR.
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2022-05-17 12:36:39 PDT
I would expect all git commands to work in pure git checkouts - for people using git-svn, there is always webkit-patch.
Alexey Proskuryakov
Comment 2
2022-05-17 12:36:56 PDT
*all git-webkit commands
Aakash Jain
Comment 3
2022-05-18 06:31:12 PDT
This bug is about pure GitHub checkout. On pure GitHub checkout, git-webkit land command currently errors out, it shouldn’t.
Radar WebKit Bug Importer
Comment 4
2022-05-18 07:27:12 PDT
<
rdar://problem/93501363
>
Jonathan Bedard
Comment 5
2022-05-18 15:24:21 PDT
***
Bug 240600
has been marked as a duplicate of this bug. ***
Jonathan Bedard
Comment 6
2022-06-22 16:55:47 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/1706
EWS
Comment 7
2022-06-22 18:03:04 PDT
Committed
r295761
(
251766@main
): <
https://commits.webkit.org/251766@main
> Reviewed commits have been landed. Closing PR #1706 and removing active labels.
Jonathan Bedard
Comment 8
2022-06-23 15:20:54 PDT
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/1747
EWS
Comment 9
2022-06-23 15:27:29 PDT
Committed
251805@main
(e358612bebec): <
https://commits.webkit.org/251805@main
> Reviewed commits have been landed. Closing PR #1747 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug