Summary: | REGRESSION(r291038) [GTK][WPE] Fix build without remote inspector | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Olivier Blin <olivier.blin> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aperez, bugs-noreply, cgarcia, loic.yhuel, mcatanzaro | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Olivier Blin
2022-05-11 06:38:54 PDT
Created attachment 459163 [details]
Patch
Comment on attachment 459163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459163&action=review > Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:126 > parameters.inspectorServerAddress = Inspector::RemoteInspector::inspectorServerAddress(); Would be nice to define it conditionally, too, so it doesn't exist at all except when ENABLE(REMOTE_INSPECTOR) is defined. Just a bit more robust to future changes, in case leaving it uninitialized is not OK in the future. Created attachment 459220 [details]
Patch
Committed r294103 (250488@main): <https://commits.webkit.org/250488@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459220 [details]. |