Bug 240275

Summary: Introduce a canvas-drawImage specific method to get a NativeImage from a video element
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sam, sergio, webkit-bug-importer, youssefdevelops, y_soliman
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2022-05-10 04:50:19 PDT
Introduce a canvas-drawImage specific method to get a NativeImage from a video element
Attachments
Patch (7.65 KB, patch)
2022-05-10 05:29 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (7.22 KB, patch)
2022-05-11 00:23 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-05-10 05:29:23 PDT
Created attachment 459110 [details] Patch
Sam Weinig
Comment 2 2022-05-10 10:22:22 PDT
Comment on attachment 459110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459110&action=review > Source/WebCore/platform/graphics/MediaPlayer.h:479 > + RefPtr<NativeImage> currentNativeImageForCanvasDrawing(); The functions above use the phrasing "ForCurrentTime" rather than just "current". Would be good to stay consistent here:` nativeImageForCanvasDrawingForCurrentTime()`
youenn fablet
Comment 3 2022-05-11 00:21:44 PDT
After discussion with Eric, a boolean getter might be a better fit.
youenn fablet
Comment 4 2022-05-11 00:23:27 PDT
Created attachment 459146 [details] Patch
EWS
Comment 5 2022-05-11 10:21:48 PDT
Committed r294057 (250461@main): <https://commits.webkit.org/250461@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459146 [details].
Radar WebKit Bug Importer
Comment 6 2022-05-11 10:22:14 PDT
<rdar://problem/93112229>
Note You need to log in before you can comment on or make changes to this bug.