| Summary: | Remove abandoned CSSDeferredParser implementation and feature flag | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, koivisto, macpherson, menard, ntim, philipj, sergio, webkit-bug-importer, youssefdevelops, y_soliman | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 165743 | ||||||
| Bug Blocks: | 240282 | ||||||
| Attachments: |
|
||||||
|
Description
Brent Fulgham
2022-05-09 11:42:42 PDT
Created attachment 459064 [details]
Patch
@Antti: Should we do something about removing the SPECIALIZE_TYPE_TRAITS bits that were added in Hyatt's original patch? Comment on attachment 459064 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459064&action=review Nice cleanup! > Source/WebCore/css/StyleProperties.h:337 > SPECIALIZE_TYPE_TRAITS_BEGIN(WebCore::StyleProperties) > - static bool isType(const WebCore::StylePropertiesBase& set) { return set.type() != WebCore::DeferredPropertiesType; } > + static bool isType(const WebCore::StylePropertiesBase&) { return true; } > SPECIALIZE_TYPE_TRAITS_END() I think we can just remove StylePropertiesBase and smash it into StyleProperties. Doesn't need to be done in this patch. (In reply to Antti Koivisto from comment #3) > I think we can just remove StylePropertiesBase and smash it into > StyleProperties. > > Doesn't need to be done in this patch. Worth filing a bug. Comment on attachment 459064 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459064&action=review >> Source/WebCore/css/StyleProperties.h:337 >> SPECIALIZE_TYPE_TRAITS_END() > > I think we can just remove StylePropertiesBase and smash it into StyleProperties. > > Doesn't need to be done in this patch. Filed Bug 240282. Will do that after this patch lands. Committed r294007 (250443@main): <https://commits.webkit.org/250443@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459064 [details]. |