Bug 240231

Summary: Add a better mock for audio units used by CoreAudioSharedUnit
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf, youssefdevelops, y_soliman
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing ews-feeder: commit-queue-

Description youenn fablet 2022-05-09 06:22:12 PDT 
Add a better mock for audio units used by CoreAudioSharedUnit
Comment 1 youenn fablet 2022-05-09 06:55:29 PDT 
Created attachment 459041 [details]
Patch
Comment 2 youenn fablet 2022-05-10 05:32:39 PDT 
Created attachment 459111 [details]
Patch
Comment 3 youenn fablet 2022-05-10 05:48:14 PDT 
Created attachment 459112 [details]
Patch
Comment 4 youenn fablet 2022-05-10 05:53:51 PDT 
Created attachment 459113 [details]
Patch
Comment 5 Eric Carlson 2022-05-10 06:28:21 PDT 
Comment on attachment 459113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459113&action=review

> Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:266
> +    auto sampleTime = PAL::toMediaTime(startTime).toFloat();

Can you just use `sampleTime = PAL::CMTimeGetSeconds(startTime)`?
Comment 6 youenn fablet 2022-05-11 00:11:22 PDT 
(In reply to Eric Carlson from comment #5)
> Comment on attachment 459113 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459113&action=review
> 
> > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:266
> > +    auto sampleTime = PAL::toMediaTime(startTime).toFloat();
> 
> Can you just use `sampleTime = PAL::CMTimeGetSeconds(startTime)`?

Yes, that seems better.
Comment 7 youenn fablet 2022-05-11 00:12:24 PDT 
Comment on attachment 459113 [details]
Patch

win failure is unrelated. Marking as r?
Comment 8 youenn fablet 2022-05-12 04:16:17 PDT 
Created attachment 459221 [details]
Patch for landing
Comment 9 EWS 2022-05-12 06:57:29 PDT 
Committed r294102 (250487@main): <https://commits.webkit.org/250487@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459221 [details].
Comment 10 Radar WebKit Bug Importer 2022-05-12 06:58:13 PDT 
<rdar://problem/93171741>