Bug 240203

Summary: [macOS] REGRESSION (r293825): Find highlight snapshots are incorrectly scaled
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Said Abou-Hallawa 2022-05-07 01:07:15 PDT
takeSnapshots() depends on the snapshot ImageBuffer::resolutionScale() to set the size of the TextIndicatorData image. r293825 scaled the size of the ImageBuffer before creation and moved the scaling to the GraphicsContext. So we have correct scaled pixels but the resolutionScale is 1. So we get enlarged incorrect image.
Comment 1 Said Abou-Hallawa 2022-05-07 01:07:41 PDT
rdar://92892014
Comment 2 Said Abou-Hallawa 2022-05-07 01:28:25 PDT
Created attachment 458994 [details]
Patch
Comment 3 Said Abou-Hallawa 2022-05-08 19:44:08 PDT
Created attachment 459020 [details]
Patch
Comment 4 EWS 2022-05-08 23:29:46 PDT
Committed r293968 (250406@main): <https://commits.webkit.org/250406@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459020 [details].