Bug 240164

Summary: Optimize shouldApplyContainment methods
Product: WebKit Reporter: Rob Buis <rbuis>
Component: Layout and RenderingAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari 15   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=240156
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2022-05-06 04:16:58 PDT
Optimize shouldApplyContainment methods by allowing OptionSet as a parameter. Also restrict the principal box checks to a single location.
Attachments
Patch (13.36 KB, patch)
2022-05-06 04:20 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (12.32 KB, patch)
2022-05-06 10:56 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2022-05-06 04:20:19 PDT
Created attachment 458946 [details] Patch
Simon Fraser (smfr)
Comment 2 2022-05-06 08:55:12 PDT
I was going to do something very similar, but first I wanted to move these functions: bug 240156
Simon Fraser (smfr)
Comment 3 2022-05-06 08:58:54 PDT
I can adapt this patch to the moved functions once bug 240156 lands.
Rob Buis
Comment 4 2022-05-06 09:04:15 PDT
(In reply to Simon Fraser (smfr) from comment #3) > I can adapt this patch to the moved functions once bug 240156 lands. Thanks, sounds good!
Simon Fraser (smfr)
Comment 5 2022-05-06 10:56:14 PDT
Created attachment 458963 [details] Patch
EWS
Comment 6 2022-05-06 19:08:13 PDT
Committed r293943 (250389@main): <https://commits.webkit.org/250389@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458963 [details].
Radar WebKit Bug Importer
Comment 7 2022-05-06 19:09:14 PDT
<rdar://problem/92893054>
Note You need to log in before you can comment on or make changes to this bug.