Summary: | [WebGPU] Fix build on downlevel OSes in Apple's build system | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Myles C. Maxfield
2022-05-06 00:35:14 PDT
Created attachment 458938 [details]
Patch
*** Bug 239923 has been marked as a duplicate of this bug. *** Comment on attachment 458938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458938&action=review > Source/WebGPU/Configurations/Base.xcconfig:27 > +#include? "<DEVELOPER_DIR>/AppleInternal/XcodeConfig/PlatformSupport.xcconfig" > #include "SDKVariant.xcconfig" > +#include "WebKitTargetConditionals.xcconfig" I see that for WebCore, these are in WebCore.xcconfig, not in Base.xcconfig. Is it possible to keep these projects similar, to reduce future confusion? Comment on attachment 458938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458938&action=review >> Source/WebGPU/Configurations/Base.xcconfig:27 >> +#include "WebKitTargetConditionals.xcconfig" > > I see that for WebCore, these are in WebCore.xcconfig, not in Base.xcconfig. Is it possible to keep these projects similar, to reduce future confusion? Oh, I was following the model of JavaScriptCore, which has them in JavaScriptCore.xcconfig. JSC does indeed have in Base.xcconfig. Ok then! Committed r293937 (250383@main): <https://commits.webkit.org/250383@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458938 [details]. |