Bug 240132

Summary: Avoid resolving style for elements that only inherit changes from parent
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jbedard, joepeck, kondapallykalyan, macpherson, menard, pdr, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 240770    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Antti Koivisto
Reported 2022-05-05 11:21:10 PDT
We may do unnecessary work in the subtree when an inherited property changes.
Attachments
Patch (17.14 KB, patch)
2022-05-05 11:23 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (27.13 KB, patch)
2022-05-07 04:26 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (27.13 KB, patch)
2022-05-07 04:28 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (27.10 KB, patch)
2022-05-07 05:14 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (27.63 KB, patch)
2022-05-07 06:59 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.63 KB, patch)
2022-05-07 22:57 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2022-05-05 11:23:11 PDT
Created attachment 458897 [details] Patch
Radar WebKit Bug Importer
Comment 2 2022-05-06 10:14:39 PDT
<rdar://problem/92867346>
Antti Koivisto
Comment 3 2022-05-07 04:26:02 PDT
Created attachment 458998 [details] Patch
Antti Koivisto
Comment 4 2022-05-07 04:28:08 PDT
Created attachment 458999 [details] Patch
Antti Koivisto
Comment 5 2022-05-07 05:14:11 PDT
Created attachment 459000 [details] Patch
Antti Koivisto
Comment 6 2022-05-07 06:59:50 PDT
Created attachment 459001 [details] Patch
Sam Weinig
Comment 7 2022-05-07 10:50:58 PDT
Comment on attachment 459001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459001&action=review > Source/WebCore/ChangeLog:10 > + is done by simply running the full style resolution for them sincluding selector matching and typo: sincluding -> including > Source/WebCore/ChangeLog:13 > + In a common case nothing changes in descendants expect the inherited properties. This patch implements typo. "In a common case" usually we say "In the common case". > Source/WebCore/css/CSSProperties.json:96 > + "Indicates that this CSS property can use fast-path inheritance mechanism.", "Indicates that this CSS property can use fast-path inheritance mechanism.", -> "Indicates that this CSS property can use the fast-path inheritance mechanism.",
Antti Koivisto
Comment 8 2022-05-07 22:57:20 PDT
Created attachment 459010 [details] Patch for landing
EWS
Comment 9 2022-05-08 00:13:30 PDT
Committed r293956 (250402@main): <https://commits.webkit.org/250402@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459010 [details].
Note You need to log in before you can comment on or make changes to this bug.