Bug 240127

Summary: Create reports for long process launch times
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ggaren, sihui_liu, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Per Arne Vollan
Reported 2022-05-05 10:46:35 PDT
We have reports that it can take a long time to launch WebKit processes in some cases. This is the time it takes from the XPC message is sent until the XPC reply is received. Add reporting when this happens in order to help diagnose the issue.
Attachments
Patch (2.55 KB, patch)
2022-05-05 10:53 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2022-05-05 10:56 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (2.52 KB, patch)
2022-05-05 10:57 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2022-05-05 11:37 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (2.52 KB, patch)
2022-05-05 13:24 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (2.34 KB, patch)
2022-05-09 09:08 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2022-05-05 10:53:30 PDT
Created attachment 458890 [details] Patch
Per Arne Vollan
Comment 2 2022-05-05 10:56:12 PDT
Created attachment 458891 [details] Patch
Per Arne Vollan
Comment 3 2022-05-05 10:57:17 PDT
Created attachment 458893 [details] Patch
Per Arne Vollan
Comment 4 2022-05-05 11:37:15 PDT
Created attachment 458900 [details] Patch
Yusuke Suzuki
Comment 5 2022-05-05 11:42:26 PDT
Comment on attachment 458900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458900&action=review > Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:190 > + WallTime m_proccessStart; Let's use MonotonicTime since WallTime can be changed by user's timezone change etc.
Per Arne Vollan
Comment 6 2022-05-05 13:24:17 PDT
Created attachment 458908 [details] Patch
Per Arne Vollan
Comment 7 2022-05-05 13:25:10 PDT
(In reply to Yusuke Suzuki from comment #5) > Comment on attachment 458900 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458900&action=review > > > Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:190 > > + WallTime m_proccessStart; > > Let's use MonotonicTime since WallTime can be changed by user's timezone > change etc. Fixed. Thanks for reviewing!
Yusuke Suzuki
Comment 8 2022-05-05 16:13:32 PDT
Comment on attachment 458908 [details] Patch r=me
Per Arne Vollan
Comment 9 2022-05-06 07:45:59 PDT
(In reply to Yusuke Suzuki from comment #8) > Comment on attachment 458908 [details] > Patch > > r=me Thanks for reviewing!
EWS
Comment 10 2022-05-06 08:59:50 PDT
Committed r293893 (250351@main): <https://commits.webkit.org/250351@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458908 [details].
Radar WebKit Bug Importer
Comment 11 2022-05-06 09:00:19 PDT
<rdar://problem/92862824>
Alexey Proskuryakov
Comment 12 2022-05-06 19:24:47 PDT
Comment on attachment 458908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458908&action=review > Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:111 > + m_proccessStart = MonotonicTime::now(); typo: proccess
Per Arne Vollan
Comment 13 2022-05-09 09:05:06 PDT
(In reply to Alexey Proskuryakov from comment #12) > Comment on attachment 458908 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458908&action=review > > > Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:111 > > + m_proccessStart = MonotonicTime::now(); > > typo: proccess Good catch, will fix. Thanks for reviewing!
Per Arne Vollan
Comment 14 2022-05-09 09:08:43 PDT
Reopening to attach new patch.
Per Arne Vollan
Comment 15 2022-05-09 09:08:45 PDT
Created attachment 459051 [details] Patch
EWS
Comment 16 2022-05-09 09:53:26 PDT
Committed r293979 (250417@main): <https://commits.webkit.org/250417@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459051 [details].
Note You need to log in before you can comment on or make changes to this bug.