Summary: | Convert inline-ignored-on-legend to text-only test | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||||
Component: | Layout and Rendering | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2009-02-18 15:53:47 PST
Created attachment 27768 [details]
Convert inline-ignored-on-legend to text-only test, v1.
LayoutTests/ChangeLog | 13 +++++++++++++
.../forms/inline-ignored-on-legend-expected.txt | 3 +++
.../fast/forms/inline-ignored-on-legend.html | 11 ++++++++++-
.../inline-ignored-on-legend-expected.checksum | 1 -
.../forms/inline-ignored-on-legend-expected.png | Bin 13718 -> 0 bytes
.../forms/inline-ignored-on-legend-expected.txt | 16 ----------------
6 files changed, 26 insertions(+), 18 deletions(-)
Comment on attachment 27768 [details]
Convert inline-ignored-on-legend to text-only test, v1.
Looks fine. MIght as well add a newline at the end of hte file while you're there.
Landed as http://trac.webkit.org/changeset/41069. Please back this change out. A text only test is not helpful here, since you need to see the pixel rendering to know how the legend ended up getting treated. Ok, I am going to try to spin again. Basically, we don't really need the pixel rendering -- all we need is making sure that legend is a block element. That's fairly easy to accomplish: <div>First Line</div>Second Line vs. <span>First Line</span>Second Line These will render differently even in text-only. Even in our existing test case, there's an extra line break in the expected result. I can "accentuate" it in the test to make it clear to the observer as to what the successful output is. Created attachment 27793 [details]
Clarify objective of the test and clean up, v1
LayoutTests/ChangeLog | 10 ++++++++++
.../forms/inline-ignored-on-legend-expected.txt | 5 +++--
.../fast/forms/inline-ignored-on-legend.html | 18 +++++++-----------
3 files changed, 20 insertions(+), 13 deletions(-)
Comment on attachment 27793 [details]
Clarify objective of the test and clean up, v1
Here's a simplified, clarified test case, which works in text-only mode.
Comment on attachment 27793 [details]
Clarify objective of the test and clean up, v1
Yeah better.
Fix/clean up landed as http://trac.webkit.org/changeset/41079. |