Bug 240112

Summary: REGRESSION (r291788): MotionMark Suits subtest is 9% regressed
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, Hironori.Fujii, kangil.han, kondapallykalyan, pdr, rbuis, sabouhallawa, schenney, sergio, zalan, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=241489
Bug Depends on:    
Bug Blocks: 230296    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Antti Koivisto 2022-05-05 01:08:02 PDT 
This is https://browserbench.org/MotionMark1.2/

Individual subtests can be ran via https://browserbench.org/MotionMark1.2/developer.html
Comment 1 Antti Koivisto 2022-05-05 01:08:27 PDT 
rdar://92409900
Comment 2 Nikolas Zimmermann 2022-05-05 13:30:17 PDT 
Hmm, that's not a small one... You found this by chance Antti? Or did the patch make you suspicious? :-)
Comment 3 zalan 2022-05-05 13:43:19 PDT 
(In reply to Nikolas Zimmermann from comment #2)
> Hmm, that's not a small one... You found this by chance Antti? Or did the
> patch make you suspicious? :-)
We run MM regularly to discover regressions (and progressions).
Comment 4 zalan 2022-05-05 20:06:22 PDT 
The Suits subtest is about calling svgElement.setAttribute('transform','translate...". in a repeated manner.

r291788 went from "attribute changed + set needsLayout" to "attribute changed + invalidate style" which is fine as long as the attribute is translated to a RenderStyle property, however SVG transform is special and internal to SVGGraphicsElement and it does not require style invalidation.

Will post a patch soon.
Comment 5 zalan 2022-05-06 08:38:25 PDT 
> Will post a patch soon.
or Antti. Probably Antti.
Comment 6 Antti Koivisto 2022-05-11 01:58:40 PDT 
Created attachment 459148 [details]
Patch
Comment 7 Antti Koivisto 2022-05-11 04:54:23 PDT 
Created attachment 459154 [details]
Patch
Comment 8 Antti Koivisto 2022-05-11 05:21:31 PDT 
Created attachment 459156 [details]
Patch
Comment 9 Antti Koivisto 2022-05-11 05:32:37 PDT 
Created attachment 459157 [details]
Patch
Comment 10 Antti Koivisto 2022-05-11 07:50:36 PDT 
Created attachment 459165 [details]
Patch
Comment 11 zalan 2022-05-11 13:03:07 PDT 
Comment on attachment 459165 [details]
Patch

v.nice
Comment 12 EWS 2022-05-11 13:36:15 PDT 
Committed r294067 (250469@main): <https://commits.webkit.org/250469@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459165 [details].
Comment 13 Fujii Hironori 2022-06-30 23:45:38 PDT 
Bug 242230 – REGRESSION(250469@main) svg/animations/animation-leak-list-property-instances.html is randomly failing