Bug 240109

Summary: Implement :modal CSS pseudo-class
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cdumez, changseok, clopez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/33999
Bug Depends on:    
Bug Blocks: 84635    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
simon.fraser: review+, ews-feeder: commit-queue-
Patch ews-feeder: commit-queue-

Tim Nguyen (:ntim)
Reported 2022-05-04 22:30:12 PDT
It's just a matter of exposing the internal :-internal-modal-dialog pseudo-class to the wild. https://github.com/w3c/csswg-drafts/issues/6965#issuecomment-1118033655
Attachments
Patch (19.36 KB, patch)
2022-05-09 11:33 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (19.43 KB, patch)
2022-05-09 11:34 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (19.43 KB, patch)
2022-05-09 11:37 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (19.43 KB, patch)
2022-05-09 11:40 PDT, Tim Nguyen (:ntim) 		simon.fraser: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (19.50 KB, patch)
2022-05-09 12:09 PDT, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-05-04 22:31:56 PDT
<rdar://problem/92775435>
Tim Nguyen (:ntim)
Comment 2 2022-05-09 11:33:04 PDT
Created attachment 459060 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2022-05-09 11:34:59 PDT
Created attachment 459061 [details] Patch
EWS Watchlist
Comment 4 2022-05-09 11:35:38 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Tim Nguyen (:ntim)
Comment 5 2022-05-09 11:37:35 PDT
Created attachment 459062 [details] Patch
Tim Nguyen (:ntim)
Comment 6 2022-05-09 11:40:07 PDT
Created attachment 459063 [details] Patch
Simon Fraser (smfr)
Comment 7 2022-05-09 12:00:08 PDT
Comment on attachment 459063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459063&action=review > Source/WebCore/html/HTMLDialogElement.cpp:169 > + Style::PseudoClassChangeInvalidation styleInvalidation(*this, CSSSelector::PseudoClassModal, newValue); > + m_isModal = newValue; Should this check if it has changed?
Tim Nguyen (:ntim)
Comment 8 2022-05-09 12:09:21 PDT
Created attachment 459065 [details] Patch
EWS
Comment 9 2022-05-09 13:38:28 PDT
Committed r293987 (250424@main): <https://commits.webkit.org/250424@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459065 [details].
Note You need to log in before you can comment on or make changes to this bug.