Summary: | Implement :modal CSS pseudo-class | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> | ||||||||||||
Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | allan.jensen, cdumez, changseok, clopez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://github.com/web-platform-tests/wpt/pull/33999 | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 84635 | ||||||||||||||
Attachments: |
|
Description
Tim Nguyen (:ntim)
2022-05-04 22:30:12 PDT
Created attachment 459060 [details]
Patch
Created attachment 459061 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 459062 [details]
Patch
Created attachment 459063 [details]
Patch
Comment on attachment 459063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459063&action=review > Source/WebCore/html/HTMLDialogElement.cpp:169 > + Style::PseudoClassChangeInvalidation styleInvalidation(*this, CSSSelector::PseudoClassModal, newValue); > + m_isModal = newValue; Should this check if it has changed? Created attachment 459065 [details]
Patch
Committed r293987 (250424@main): <https://commits.webkit.org/250424@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459065 [details]. |