Bug 240102
| Summary: | [JSC] Intl.NumberFormat lacks some validation for rounding-increment | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> |
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | angelos, mcatanzaro, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Yusuke Suzuki
[JSC] Intl.NumberFormat lacks some validation for rounding-increment
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yusuke Suzuki
Pull request: https://github.com/WebKit/WebKit/pull/517
EWS
Committed r293813 (250286@main): <https://commits.webkit.org/250286@main>
Reviewed commits have been landed. Closing PR #517 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/92768775>
Michael Catanzaro
It introduced failures when running with cloop:
Running stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: Exception: RangeError: maximum and minimum fraction-digits are not equal while roundingIncrement is specified
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: NumberFormat@[native code]
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: @intl-numberformat-rounding-increment-resolved-match-v3.js:39:35
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: forEach@[native code]
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: global code@intl-numberformat-rounding-increment-resolved-match-v3.js:38:32
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default
Running stress/intl-numberformat-rounding-increment-v3.js.default
stress/intl-numberformat-rounding-increment-v3.js.default: Exception: RangeError: maximum and minimum fraction-digits are not equal while roundingIncrement is specified
stress/intl-numberformat-rounding-increment-v3.js.default: NumberFormat@[native code]
stress/intl-numberformat-rounding-increment-v3.js.default: @intl-numberformat-rounding-increment-v3.js:52:26
stress/intl-numberformat-rounding-increment-v3.js.default: forEach@[native code]
stress/intl-numberformat-rounding-increment-v3.js.default: global code@intl-numberformat-rounding-increment-v3.js:51:32
stress/intl-numberformat-rounding-increment-v3.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/intl-numberformat-rounding-increment-v3.js.default
stress/intl-numberformat-rounding-increment-value.js.default: Exception: RangeError: maximum and minimum fraction-digits are not equal while roundingIncrement is specified
stress/intl-numberformat-rounding-increment-value.js.default: NumberFormat@[native code]
stress/intl-numberformat-rounding-increment-value.js.default: global code@intl-numberformat-rounding-increment-value.js:7:31
stress/intl-numberformat-rounding-increment-value.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/intl-numberformat-rounding-increment-value.js.default
I suppose I'd better print the values that are being compared to see what's up.
Yusuke Suzuki
Committed r293858 (250323@trunk): <https://commits.webkit.org/250323@trunk>
Angelos Oikonomopoulos
See also https://bugs.webkit.org/show_bug.cgi?id=240138.
Michael Catanzaro
(In reply to Yusuke Suzuki from comment #5)
> Committed r293858 (250323@trunk): <https://commits.webkit.org/250323@trunk>
Thanks, that fixed it.