Bug 240099

Summary: REGRESSION (r293716): macCatalyst WebKit build fails; overlapping content at /System/Library/FeatureFlags/Domain/WebKit.plist
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit Misc.Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, emw, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Tim Horton
Reported 2022-05-04 17:21:34 PDT
REGRESSION (r293716): macCatalyst WebKit build fails; overlapping content at /System/Library/FeatureFlags/Domain/WebKit.plist
Attachments
patch (4.73 KB, patch)
2022-05-04 17:22 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2022-05-04 17:21:46 PDT
<rdar://92751323>
Tim Horton
Comment 2 2022-05-04 17:22:09 PDT
Created attachment 458838 [details] patch
EWS
Comment 3 2022-05-04 21:24:50 PDT
Committed r293818 (250291@main): <https://commits.webkit.org/250291@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458838 [details].
Alexey Proskuryakov
Comment 4 2022-05-04 22:22:45 PDT
Comment on attachment 458838 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=458838&action=review > Source/WebKit/WebKit.xcodeproj/project.pbxproj:16134 > + outputPaths = ( No outputPaths???
Tim Horton
Comment 5 2022-05-04 22:43:10 PDT
(In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 458838 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458838&action=review > > > Source/WebKit/WebKit.xcodeproj/project.pbxproj:16134 > > + outputPaths = ( > > No outputPaths??? Hmm, a bit odd. I was following the one a few steps down called "Copy Daemon Plists", which also doesn't have outputPaths... I guess they're both wrong?
Elliott Williams
Comment 6 2022-05-05 08:53:06 PDT
(In reply to Tim Horton from comment #5) > (In reply to Alexey Proskuryakov from comment #4) > > Comment on attachment 458838 [details] > > patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=458838&action=review > > > > > Source/WebKit/WebKit.xcodeproj/project.pbxproj:16134 > > > + outputPaths = ( > > > > No outputPaths??? > > Hmm, a bit odd. I was following the one a few steps down called "Copy Daemon > Plists", which also doesn't have outputPaths... I guess they're both wrong? It's not really a problem here, since I'm assuming there aren't other tasks in the build which take these /System/Library/FeatureFlags/* paths as inputs.
Alexey Proskuryakov
Comment 7 2022-05-05 09:51:42 PDT
Does this make the script run unnecessarily during incremental builds?
Elliott Williams
Comment 8 2022-05-05 14:53:55 PDT
(In reply to Alexey Proskuryakov from comment #7) > Does this make the script run unnecessarily during incremental builds? You're right, it does! That does seem like a meaningful downside :(
Note You need to log in before you can comment on or make changes to this bug.