Summary: | [GitHub] git-webkit pr doesn't sort Xcode project files before uploading | ||
---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | jbedard, webkit-bug-importer, ysuzuki |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=254703 | ||
Bug Depends on: | |||
Bug Blocks: | 239082, 254703 |
Description
Chris Dumez
2022-05-02 11:33:50 PDT
There isn't a way for us to control this. PRs aren't patches, this is basically about how GitHub visualizes diffs between branches. I think you misunderstood. If webkit-patch can sort Xcode files before uploading the patch, `git-webkit pr` can also sort Xcode files before uploading the PR. If not, please provide a better explanation. We don't want Xcode project files to be unsorted in the WebKit repository. See Tools/Scripts/sort-Xcode-project-file (which we normally don't have to call manually because it get called before upload). Talking with Chris, I misunderstood the ask here. We do this sorting on disk prior to uploading the patch. We can do something similar with PRs. Pull request: https://github.com/WebKit/WebKit/pull/948 Committed r294748 (250916@main): <https://commits.webkit.org/250916@main> Reviewed commits have been landed. Closing PR #948 and removing active labels. |