Bug 239965
| Summary: | [@page] "size" should only parse as a descriptor, not a global CSS property | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oriol Brufau <obrufau> |
| Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, gsnedders, ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://wpt.live/css/css-page/parsing/size-invalid.html | ||
Oriol Brufau
https://drafts.csswg.org/css-page-3/#page-size-prop says that "size" is a property but it's clearly wrong, it's a descriptor, see https://github.com/w3c/csswg-drafts/issues/5969
Then,
CSS.supports("size: initial");
// Expected: false
// Webkit: true
// Blink: true
// Gecko: false
[...getComputedStyle(document.documentElement)].includes("size");
// Expected: false
// Webkit: true
// Blink: false
// Gecko: false
Note "system" for @counter-style works well everywhere: https://drafts.csswg.org/css-counter-styles-3/#counter-style-system
CSS.supports("system: initial"); // false
[...getComputedStyle(document.documentElement)].includes("system"); // false
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/92963022>
Sam Sneddon [:gsnedders]
(In reply to Oriol Brufau from comment #0)
> https://drafts.csswg.org/css-page-3/#page-size-prop says that "size" is a
> property but it's clearly wrong, it's a descriptor, see
> https://github.com/w3c/csswg-drafts/issues/5969
>
> Then,
>
> CSS.supports("size: initial");
> // Expected: false
> // Webkit: true
> // Blink: true
> // Gecko: false
Bug 217802 fixes this (as it's needed to avoid various asserts).
>
> [...getComputedStyle(document.documentElement)].includes("size");
> // Expected: false
> // Webkit: true
> // Blink: false
> // Gecko: false
This is a much broader issue, see https://github.com/w3c/csswg-drafts/issues/5649.
> Note "system" for @counter-style works well everywhere:
> https://drafts.csswg.org/css-counter-styles-3/#counter-style-system
>
> CSS.supports("system: initial"); // false
> [...getComputedStyle(document.documentElement)].includes("system"); //
> false
Is that just because @counter-style is disabled by default? If you try "unicode-range" (of @font-face) you should see the same as with "size".
Sam Sneddon [:gsnedders]
(In reply to Sam Sneddon [:gsnedders] from comment #2)
> This is a much broader issue, see
> https://github.com/w3c/csswg-drafts/issues/5649.
Oh, finally found it: bug 217627.
Basically I think this is just reporting the symptoms of CSS.supports returning true for descriptors (dunno if we have any actual specific bug for that), which Bug 217802 fixes, and that other bug. Maybe close as dupe?
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/15870
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/31594
EWS
Committed 281720@main (4d0b0c1943c5): <https://commits.webkit.org/281720@main>
Reviewed commits have been landed. Closing PR #31594 and removing active labels.