Bug 239819

Summary: WebGPU doesn't create a symlink to the system content path in installhdrs
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: WebGPUAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, mmaxfield, sabouhallawa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Description Michael Saboff 2022-04-27 12:55:54 PDT 
We need to create the symlink to the system content when we install headers in the build tree because WebCore needs them in the alternate root path when it builds PAL.
Comment 1 Michael Saboff 2022-04-27 12:56:14 PDT 
<rdar://91769511>
Comment 2 Michael Saboff 2022-04-27 13:06:02 PDT 
Created attachment 458461 [details]
Patch
Comment 3 Said Abou-Hallawa 2022-04-27 14:00:42 PDT 
Comment on attachment 458461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458461&action=review

> Source/WebGPU/ChangeLog:3
> +        WebGPU is doesn't create a symlink to the system content path in installhdrs

Nit: WebGPU doesn't ...
Comment 4 Michael Saboff 2022-04-27 14:22:35 PDT 
Created attachment 458468 [details]
Patch for landing
Comment 5 Michael Saboff 2022-04-27 14:26:43 PDT 
(In reply to Said Abou-Hallawa from comment #3)
> Comment on attachment 458461 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458461&action=review
> 
> > Source/WebGPU/ChangeLog:3
> > +        WebGPU is doesn't create a symlink to the system content path in installhdrs
> 
> Nit: WebGPU doesn't ...

Fixed.
Comment 6 Michael Saboff 2022-04-27 14:27:42 PDT 
Created attachment 458470 [details]
Patch for landing
Comment 7 EWS 2022-04-27 20:06:10 PDT 
Committed r293558 (250072@main): <https://commits.webkit.org/250072@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458470 [details].