WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
239819
WebGPU doesn't create a symlink to the system content path in installhdrs
https://bugs.webkit.org/show_bug.cgi?id=239819
Summary
WebGPU doesn't create a symlink to the system content path in installhdrs
Michael Saboff
Reported
2022-04-27 12:55:54 PDT
We need to create the symlink to the system content when we install headers in the build tree because WebCore needs them in the alternate root path when it builds PAL.
Attachments
Patch
(1.29 KB, patch)
2022-04-27 13:06 PDT
,
Michael Saboff
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.30 KB, patch)
2022-04-27 14:22 PDT
,
Michael Saboff
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.29 KB, patch)
2022-04-27 14:27 PDT
,
Michael Saboff
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2022-04-27 12:56:14 PDT
<
rdar://91769511
>
Michael Saboff
Comment 2
2022-04-27 13:06:02 PDT
Created
attachment 458461
[details]
Patch
Said Abou-Hallawa
Comment 3
2022-04-27 14:00:42 PDT
Comment on
attachment 458461
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=458461&action=review
> Source/WebGPU/ChangeLog:3 > + WebGPU is doesn't create a symlink to the system content path in installhdrs
Nit: WebGPU doesn't ...
Michael Saboff
Comment 4
2022-04-27 14:22:35 PDT
Created
attachment 458468
[details]
Patch for landing
Michael Saboff
Comment 5
2022-04-27 14:26:43 PDT
(In reply to Said Abou-Hallawa from
comment #3
)
> Comment on
attachment 458461
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=458461&action=review
> > > Source/WebGPU/ChangeLog:3 > > + WebGPU is doesn't create a symlink to the system content path in installhdrs > > Nit: WebGPU doesn't ...
Fixed.
Michael Saboff
Comment 6
2022-04-27 14:27:42 PDT
Created
attachment 458470
[details]
Patch for landing
EWS
Comment 7
2022-04-27 20:06:10 PDT
Committed
r293558
(
250072@main
): <
https://commits.webkit.org/250072@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 458470
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug