Bug 239808

Summary: Make -webkit-transform-style an alias of transform-style
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, koivisto, kondapallykalyan, macpherson, menard, obrufau, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 239579, 240341    
Attachments:
Description Flags
Patch
koivisto: review+, ntim: commit-queue-
Patch none

Tim Nguyen (:ntim)
Reported 2022-04-27 07:21:53 PDT
Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and simplifies code as well given the FIXME was never addressed.
Attachments
Patch (9.74 KB, patch)
2022-04-27 08:36 PDT, Tim Nguyen (:ntim) 		koivisto: review+
ntim: commit-queue-
DetailsFormatted DiffDiff
Patch (23.40 KB, patch)
2022-04-27 11:53 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2022-04-27 08:36:23 PDT
Created attachment 458449 [details] Patch
Oriol Brufau
Comment 2 2022-04-27 10:36:04 PDT
You will need to update the expectations for these tests: fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html svg/css/getComputedStyle-basic.xhtml
Tim Nguyen (:ntim)
Comment 3 2022-04-27 11:53:39 PDT
Created attachment 458456 [details] Patch
Tim Nguyen (:ntim)
Comment 4 2022-04-27 12:05:16 PDT
Committed r293524 (250055@trunk): <https://commits.webkit.org/250055@trunk>
Radar WebKit Bug Importer
Comment 5 2022-04-27 12:06:14 PDT
<rdar://problem/92412686>
EWS
Comment 6 2022-04-27 12:06:50 PDT
Found 5 new test failures: fast/css/getComputedStyle/computed-style-without-renderer.html, fast/css/getComputedStyle/computed-style.html, imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html, imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html, svg/css/getComputedStyle-basic.xhtml
Note You need to log in before you can comment on or make changes to this bug.