| Summary: | [RISCV64] Implement MacroAssemblerRISCV64 branchAtomicWeakCAS{8,16,32,64} methods | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 237775 | ||||||||
| Attachments: |
|
||||||||
Created attachment 458430 [details]
Patch
Comment on attachment 458430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458430&action=review r=me with nit.D > Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3366 > + { > + Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero); > + failure.link(this); > + return JumpList(success); > + } style is, case Success: { ... } > Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3405 > + { > + Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero); > + failure.link(this); > + return JumpList(success); > + } Ditto. > Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3432 > + { > + Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero); > + failure.link(this); > + return JumpList(success); > + } Ditto. Created attachment 458507 [details]
Patch for landing
With style changes.
Comment on attachment 458507 [details] Patch for landing Clearing flags on attachment: 458507 Committed r293571 (250085@trunk): <https://commits.webkit.org/250085@trunk> All reviewed patches have been landed. Closing bug. |
[RISCV64] Implement MacroAssemblerRISCV64 branchAtomicWeakCAS{8,16,32,64} methods