Bug 239731
| Summary: | `merge-block` label added by one EWS bot prevents other EWS bots from processing the patch | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | jbedard, ysuzuki |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Chris Dumez
`merge-block` label added by one EWS bot prevents other EWS bots from processing the patch.
I upload a PR, it fails on one of the EWS bots (due to flakiness or just a fluke). The `merge-block` label will get added to my PR and other EWS bots will just not process my PR any longer. This is super annoying.
I need feedback from other bots.
One example where it is particularly bad is when the style bot is failing, why should it prevent testing? There are plenty of cases where we choose the ignore the style bot because it is wrong.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Also, I tried removing the `merge-blocked` keyword manually and it didn't seem to unblock the other EWS (I had to reupload my PR).
Jonathan Bedard
Patch based EWS does this too with cq-!
This problem is much worse with PRs because of https://bugs.webkit.org/show_bug.cgi?id=239411, which I do intend to resolve shortly.
*** This bug has been marked as a duplicate of bug 239411 ***
Yusuke Suzuki
Nice!
Jonathan Bedard
*** This bug has been marked as a duplicate of bug 240169 ***
Jonathan Bedard
My comment about "patch based EWS doing this too with cq-" is incorrect. Patch based EWS does this with r-, the important difference being that bots don't ever automatically apply r- to patches like they do merging-blocked to PRs.