Bug 239681
| Summary: | [Xcode] Compute PGO profdata paths instead of searching for them at build time | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 239795, 241065 | ||
| Bug Blocks: | |||
Elliott Williams
Currently, the "Copy Profiling Data" script phases find profdata to use by checking BUILT_PRODUCTS_DIR, then the SDK, and finally falling back to the default profdata stub in SRCROOT. This can cause problems if stale profdata is present in BUILT_PRODUCTS_DIR and a production build is updating SDK content. It also confuses XCBuild's dependency validation on open-source builds, because the build system expects the SDK and WebKitAdditions paths to always exist.
Instead of this dynamic approach, we can compute the expected path in xcconfigs, based on the active build settings.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/367
Radar WebKit Bug Importer
<rdar://problem/92200351>
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/369
EWS
Committed r293442 (249997@main): <https://commits.webkit.org/249997@main>
Reviewed commits have been landed. Closing PR #367 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 239795
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/1031
EWS
Committed r294952 (251060@main): <https://commits.webkit.org/251060@main>
Reviewed commits have been landed. Closing PR #1031 and removing active labels.
Alexey Proskuryakov
This patch was reverted in https://commits.webkit.org/251100@main
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/1171
EWS
Committed r295065 (251160@main): <https://commits.webkit.org/251160@main>
Reviewed commits have been landed. Closing PR #1171 and removing active labels.