| Summary: | Web Inspector: request interception should not be guarded based on service workers | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, joepeck, pangle, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Devin Rousso
2022-04-22 16:48:55 PDT
Created attachment 458188 [details]
Patch
Created attachment 458201 [details]
Patch
Comment on attachment 458201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458201&action=review r=me > Source/WebCore/inspector/InspectorInstrumentation.cpp:848 > +bool InspectorInstrumentation::shouldInterceptRequestImpl(InstrumentingAgents& instrumentingAgents, ResourceLoader& loader) As far as I can tell, everything we do with the ResourceLoader can be done with a const ref – is there a reason we aren't passing `const ResourceLoader&` throughout instead? > Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:1121 > + return shouldIntercept(loader.request().url(), Protocol::Network::NetworkStage::Request); Nit: I think we can just `loader.url()` Created attachment 458285 [details]
Patch
Committed r293368 (249968@main): <https://commits.webkit.org/249968@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458285 [details]. |