Bug 239646

Summary: Remove adjustPathForRecentRenamings from VCSUtils.pm, they are not recent anymore
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: Tools / TestsAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, gsnedders, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=243447
Attachments:
Description Flags
Patch
none
Patch none

Kimmo Kinnunen
Reported 2022-04-22 02:55:33 PDT
Remove adjustPathForRecentRenamings from VCSUtils.pm, they are not recent anymore
Attachments
Patch (2.13 KB, patch)
2022-04-22 02:58 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (2.38 KB, patch)
2022-04-26 00:11 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2022-04-22 02:58:59 PDT
Created attachment 458127 [details] Patch
Kimmo Kinnunen
Comment 2 2022-04-26 00:11:32 PDT
Created attachment 458334 [details] Patch
EWS
Comment 3 2022-04-26 22:41:39 PDT
Committed r293498 (250031@main): <https://commits.webkit.org/250031@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458334 [details].
Radar WebKit Bug Importer
Comment 4 2022-04-26 22:42:12 PDT
<rdar://problem/92378815>
Darin Adler
Comment 5 2022-04-27 14:21:03 PDT
Comment on attachment 458334 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458334&action=review > Tools/Scripts/VCSUtils.pm:-856 > - # The first and second paths can differ in the case of copies > - # and renames. We use the second file path because it is the > - # destination path. Just noticed this comment. Was there a reason to remove it?
Kimmo Kinnunen
Comment 6 2022-04-28 03:58:15 PDT
Comment on attachment 458334 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458334&action=review >> Tools/Scripts/VCSUtils.pm:-856 >> - # destination path. > > Just noticed this comment. Was there a reason to remove it? It's a stale comment from the era when the logic of parseGitDiffStartLine was inline in this function, and the regex extracted both the first path and second path from the match. There's no "first path" nor "second path" in this context anymore. parseGitDiffStartLine documents that it returns the destination file for each file diff section in a git patch. bug 38628
Note You need to log in before you can comment on or make changes to this bug.