Bug 239628

Summary: Remove XSS Auditor: Part 4 (Settings)
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Brent Fulgham
Reported 2022-04-21 16:00:56 PDT
When working on Bug 230661 I neglected to remove the WebPreferences.yaml bits of the feature. This patch removes those bits, but still leaves the deprecated stub methods on WKPreferencesRef and WebPreferencesPrivate to avoid breaking any existing binaries that might reference those methods.
Attachments
Patch (2.82 KB, patch)
2022-04-21 16:03 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.35 KB, patch)
2022-04-21 18:06 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2022-04-21 16:03:40 PDT
Created attachment 458100 [details] Patch
Yusuke Suzuki
Comment 2 2022-04-21 16:54:52 PDT
👍 Nice!!
EWS
Comment 3 2022-04-21 17:06:17 PDT
Committed r293199 (249872@main): <https://commits.webkit.org/249872@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458100 [details].
Radar WebKit Bug Importer
Comment 4 2022-04-21 17:07:15 PDT
<rdar://problem/92131006>
Brent Fulgham
Comment 5 2022-04-21 18:06:26 PDT
Reopening to attach new patch.
Brent Fulgham
Comment 6 2022-04-21 18:06:28 PDT
Created attachment 458107 [details] Patch for landing
Brent Fulgham
Comment 7 2022-04-21 18:58:16 PDT
I did not properly account for Windows in the first patch, so have corrected that in a follow-up.
EWS
Comment 8 2022-04-21 19:49:49 PDT
Committed r293205 (249876@main): <https://commits.webkit.org/249876@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458107 [details].
Note You need to log in before you can comment on or make changes to this bug.