Bug 23959

Summary: LayoutTests/fast/dom/navigator-detached-no-crash.html fails with other JS engines
Product: WebKit Reporter: Jay Campan <jcampan>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Changes the test so it sorts the properties and functions before logging them
ap: review+
New patch with ChangeLog fixed. none

Jay Campan
Reported 2009-02-13 17:29:04 PST
The layout test fast/dom/navigator-detached-no-crash.html fails with V8 as it iterates the properties and methods of the navigator object and log them as they are reported. JSC and V8 report these properties in different order (which is OK by JS specs I believe) causing the test to fail with Chromium. The test should probably sort these props before logging them so the order would always be the same.
Attachments
Changes the test so it sorts the properties and functions before logging them (3.85 KB, patch)
2009-02-13 17:30 PST, Jay Campan 		ap: review+
DetailsFormatted DiffDiff
New patch with ChangeLog fixed. (3.38 KB, patch)
2009-02-17 15:01 PST, Jay Campan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jay Campan
Comment 1 2009-02-13 17:30:49 PST
Created attachment 27677 [details] Changes the test so it sorts the properties and functions before logging them
Alexey Proskuryakov
Comment 2 2009-02-14 02:40:46 PST
Do IE and Firefox sort these properties in the same order as WebKit?
Alexey Proskuryakov
Comment 3 2009-02-17 02:17:24 PST
Comment on attachment 27677 [details] Changes the test so it sorts the properties and functions before logging them Ok, Firefox sorts differently, so r=me. But this patch includes a wrong ChangeLog, which must be fixed.
Jay Campan
Comment 4 2009-02-17 15:01:40 PST
Created attachment 27739 [details] New patch with ChangeLog fixed. ChangeLog fixed in new attachment (sorry, forgot to run prepare-changelog previously)
Dmitry Titov
Comment 5 2009-02-19 14:20:44 PST
Landed in http://trac.webkit.org/changeset/41087 The ChangeLog usually includes a link to the bug in Bugzilla and a short description of changes. I've fixed it up and landed.
Note You need to log in before you can comment on or make changes to this bug.