Bug 239540

Summary: [IFC][Integration] Do not call WebPreferences::simpleLineLayoutEnabled in canUseForLineLayoutWithReason
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2022-04-20 06:18:38 PDT
ssia
Attachments
Patch (24.03 KB, patch)
2022-04-20 06:23 PDT, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (356.44 KB, patch)
2022-04-20 08:33 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (356.44 KB, patch)
2022-04-20 08:36 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (357.27 KB, patch)
2022-04-20 10:49 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (391.74 KB, patch)
2022-04-20 12:35 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-04-20 06:23:44 PDT
Created attachment 457984 [details] Patch
Antti Koivisto
Comment 2 2022-04-20 07:14:54 PDT
Comment on attachment 457984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457984&action=review > Source/WebCore/ChangeLog:8 > + 1. Use RuntimeEnabledFeatures::sharedFeatures() instead of Page::Settgins. Settings
alan
Comment 3 2022-04-20 08:33:28 PDT
Created attachment 457991 [details] Patch
alan
Comment 4 2022-04-20 08:36:50 PDT
Created attachment 457992 [details] Patch
Simon Fraser (smfr)
Comment 5 2022-04-20 09:11:29 PDT
Comment on attachment 457992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457992&action=review > Source/WTF/ChangeLog:3 > + [IFC][Integration] Do not WebPreferences::simpleLineLayoutEnabled in canUseForLineLayoutWithReason Do not what?
alan
Comment 6 2022-04-20 10:49:27 PDT
Created attachment 457997 [details] Patch
alan
Comment 7 2022-04-20 12:35:42 PDT
Created attachment 458004 [details] Patch
EWS
Comment 8 2022-04-20 14:27:12 PDT
Committed r293114 (249820@main): <https://commits.webkit.org/249820@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458004 [details].
Radar WebKit Bug Importer
Comment 9 2022-04-20 14:28:15 PDT
<rdar://problem/92051859>
Note You need to log in before you can comment on or make changes to this bug.