Bug 239540 - [IFC][Integration] Do not call WebPreferences::simpleLineLayoutEnabled in canUseForLineLayoutWithReason
Summary: [IFC][Integration] Do not call WebPreferences::simpleLineLayoutEnabled in can...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-20 06:18 PDT by zalan
Modified: 2022-04-20 14:28 PDT (History)
12 users (show)

See Also:


Attachments
Patch (24.03 KB, patch)
2022-04-20 06:23 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (356.44 KB, patch)
2022-04-20 08:33 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (356.44 KB, patch)
2022-04-20 08:36 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (357.27 KB, patch)
2022-04-20 10:49 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (391.74 KB, patch)
2022-04-20 12:35 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-04-20 06:18:38 PDT
ssia
Comment 1 zalan 2022-04-20 06:23:44 PDT
Created attachment 457984 [details]
Patch
Comment 2 Antti Koivisto 2022-04-20 07:14:54 PDT
Comment on attachment 457984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457984&action=review

> Source/WebCore/ChangeLog:8
> +        1. Use RuntimeEnabledFeatures::sharedFeatures() instead of Page::Settgins.

Settings
Comment 3 zalan 2022-04-20 08:33:28 PDT
Created attachment 457991 [details]
Patch
Comment 4 zalan 2022-04-20 08:36:50 PDT
Created attachment 457992 [details]
Patch
Comment 5 Simon Fraser (smfr) 2022-04-20 09:11:29 PDT
Comment on attachment 457992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457992&action=review

> Source/WTF/ChangeLog:3
> +        [IFC][Integration] Do not WebPreferences::simpleLineLayoutEnabled in canUseForLineLayoutWithReason

Do not what?
Comment 6 zalan 2022-04-20 10:49:27 PDT
Created attachment 457997 [details]
Patch
Comment 7 zalan 2022-04-20 12:35:42 PDT
Created attachment 458004 [details]
Patch
Comment 8 EWS 2022-04-20 14:27:12 PDT
Committed r293114 (249820@main): <https://commits.webkit.org/249820@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458004 [details].
Comment 9 Radar WebKit Bug Importer 2022-04-20 14:28:15 PDT
<rdar://problem/92051859>