Bug 239516

Summary: Various WebKit tools need to be told about the system content path
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, emw, ews-watchlist, keith_miller, mark.lam, ryanhaddad, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Updated Patch ryanhaddad: review+

Michael Saboff
Reported 2022-04-19 13:10:45 PDT
When we build JavaScriptCore tools with the system content path, they end up in the standard path. We need to add the system content path to the install path.
Attachments
Patch (2.13 KB, patch)
2022-04-19 13:22 PDT, Michael Saboff 		darin: review+
DetailsFormatted DiffDiff
Updated Patch (7.60 KB, patch)
2022-04-19 15:40 PDT, Michael Saboff 		ryanhaddad: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2022-04-19 13:11:01 PDT
<rdar://91910145>
Michael Saboff
Comment 2 2022-04-19 13:22:09 PDT
Created attachment 457932 [details] Patch
Darin Adler
Comment 3 2022-04-19 13:26:24 PDT
Comment on attachment 457932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457932&action=review > Source/JavaScriptCore/ChangeLog:9 > + This will and the system content path prefix when enabled. "This will and the"?
Michael Saboff
Comment 4 2022-04-19 13:39:45 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 457932 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457932&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + This will and the system content path prefix when enabled. > > "This will and the"? Will fix.
Michael Saboff
Comment 5 2022-04-19 15:07:59 PDT
Through some local testing, the WebKit testing tools like DumpRenderTree and WebKitTestRunner need to be educated about the system content path. Patch forthcoming.
Michael Saboff
Comment 6 2022-04-19 15:40:23 PDT
Created attachment 457939 [details] Updated Patch Added changes for WebKit testing tools.
Michael Saboff
Comment 7 2022-04-19 16:23:32 PDT
Committed r293043 (249782@trunk): <https://commits.webkit.org/249782@trunk>
Note You need to log in before you can comment on or make changes to this bug.