Bug 23944

Summary: KURLGoogle's pre-parsed canonicalSpec constructor should take a CString
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: PlatformAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch eric: review+

Darin Fisher (:fishd, Google)
Reported 2009-02-12 22:44:18 PST
KURLGoogle's pre-parsed canonicalSpec constructor should take a CString Internally it allocates a CString, so this would not be a significant change for any existing code. This change would allow us to efficiently copy from KURL -> CString -> KURL since CString is internally reference counted. I plan to leverage this in our WebKit layer.
Attachments
v1 patch (6.23 KB, patch)
2009-02-12 22:52 PST, Darin Fisher (:fishd, Google) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2009-02-12 22:52:32 PST
Created attachment 27643 [details] v1 patch This patch was already reviewed by Brett Wilson (the author of KURLGoogle) here: http://codereview.chromium.org/21343
Eric Seidel (no email)
Comment 2 2009-02-12 23:50:08 PST
Comment on attachment 27643 [details] v1 patch Looks fine to me. I much prefer CString over char* + len anyway!
Darin Fisher (:fishd, Google)
Comment 3 2009-02-13 11:01:58 PST
http://trac.webkit.org/changeset/40981
Note You need to log in before you can comment on or make changes to this bug.