Bug 239415

Summary: Fix duplicate headers warning in libwebrtc Copy Headers phase
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: emw, eric.carlson, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tim Horton
Reported 2022-04-15 23:32:35 PDT
Fix duplicate headers warning in libwebrtc Copy Headers phase
Attachments
Patch (7.96 KB, patch)
2022-04-15 23:33 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2022-04-15 23:33:05 PDT
Created attachment 457743 [details] Patch
Tim Horton
Comment 2 2022-04-15 23:34:04 PDT
(I don't actually understand the ownership of these files -- are they imported like the rest of libwebrtc? Will these changes persist?)
Radar WebKit Bug Importer
Comment 3 2022-04-22 23:33:13 PDT
<rdar://problem/92207078>
Elliott Williams
Comment 4 2022-04-25 11:43:23 PDT
Looks good, r=me. (In reply to Tim Horton from comment #2) > (I don't actually understand the ownership of these files -- are they > imported like the rest of libwebrtc? Will these changes persist?) These file references were added in a somewhat-painstaking manual process as part of the XCBuild migration. I'm guessing they got duplicated due to merge conflict fallout or me dragging and dropping them somewhere weird. I'd be surprised if Xcode is at fault and the change doesn't persist.
Tim Horton
Comment 5 2022-04-25 12:23:42 PDT
(In reply to Elliott Williams from comment #4) > Looks good, r=me. > > (In reply to Tim Horton from comment #2) > > (I don't actually understand the ownership of these files -- are they > > imported like the rest of libwebrtc? Will these changes persist?) > > These file references were added in a somewhat-painstaking manual process as > part of the XCBuild migration. I'm guessing they got duplicated due to merge > conflict fallout or me dragging and dropping them somewhere weird. I'd be > surprised if Xcode is at fault and the change doesn't persist. Not the ownership I meant -- I meant "does WebKit own these or do they get imported from some external project (see "ThirdParty"). But I think we maybe do own them?
EWS
Comment 6 2022-04-25 13:10:28 PDT
Committed r293341 (249962@main): <https://commits.webkit.org/249962@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457743 [details].
Elliott Williams
Comment 7 2022-04-25 14:25:01 PDT
(In reply to Tim Horton from comment #5) > Not the ownership I meant -- I meant "does WebKit own these or do they get > imported from some external project (see "ThirdParty"). But I think we maybe > do own them? Ah, yeah. I believe we own the Xcode project file and have never attempted to upstream changes to it.
Note You need to log in before you can comment on or make changes to this bug.