Bug 239411 – GitHub EWS is confused with prior PR's merge-blocked label

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Yusuke Suzuki]

If we update PRs multiple times in a short period,

1. The former EWS run is still running while new PR is uploaded
2. The former EWS puts `merge-blocked` label if it failed, even though a new change is uploaded to this PR
3. If the former EWS puts `merge-blocked` accidentally, it prevents us from running EWS tests in a new PR

So, EWS should put `merge-blocked` label only when PR's latest change matches to the patch of EWS.

[Aakash Jain]

Also, it might make sense to automatically remove 'merge-blocked' label while uploading new version of the PR, using 'git-webkit pr' command.

[Michael Catanzaro]

(In reply to Yusuke Suzuki from comment #0)
> 1. The former EWS run is still running while new PR is uploaded

:/ Ideally a force push would immediately cancel any previous EWS runs.

[Yusuke Suzuki]

Right now, it is hard to run EWS tests on GitHub because of this issue.
Previous EWS runs slowly and puts merge-blocked label at random time,
and which blocks newly scheduled EWS tests.

[Jonathan Bedard]

(In reply to Aakash Jain from comment #1)
> Also, it might make sense to automatically remove 'merge-blocked' label
> while uploading new version of the PR, using 'git-webkit pr' command.

We already do that.

[Yusuke Suzuki]

In https://bugs.webkit.org/show_bug.cgi?id=239613, it seems that we failed to run EWS on GitHub because of this and it was labeled with check-mark.

[Radar WebKit Bug Importer]

<rdar://problem/92196846>

[Jonathan Bedard]

*** Bug 239731 has been marked as a duplicate of this bug. ***

[Jonathan Bedard]

Pull request: https://github.com/WebKit/WebKit/pull/380

[EWS]

Committed r293381 (249971@main): <https://commits.webkit.org/249971@main>

Reviewed commits have been landed. Closing PR #380 and removing active labels.