Bug 239396
| Summary: | [PGO] Fix build on intel machines | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Michaud <justin_michaud> |
| Component: | Tools / Tests | Assignee: | Justin Michaud <justin_michaud> |
| Status: | RESOLVED FIXED | ||
| Severity: | Critical | CC: | cdumez, emw, justin_michaud, saam, webkit-bug-importer, wenson_hsieh |
| Priority: | P1 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Mac (Intel) | ||
| OS: | Unspecified | ||
Justin Michaud
For some reason this was never an issue on AS, but we should use the correct operator for string comparison.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Justin Michaud
Argument "ON" isn't numeric in numeric eq (==) at ../../Tools/Scripts/check-for-weak-vtables-and-externals line 63.
Use of uninitialized value $ENV{"ENABLE_LLVM_PROFILE_GENERATION"} in numeric eq (==) at ../../Tools/Scripts/check-for-weak-vtables-and-externals line 63.
Justin Michaud
Pull request: https://github.com/WebKit/WebKit/pull/299
EWS
Committed r292962 (249727@main): <https://commits.webkit.org/249727@main>
Reviewed commits have been landed. Closing PR #299 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/91907374>