Bug 239393

Summary: Apply purifyNaN in more places.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
saam: review+
patch for landing. none

Mark Lam
Reported 2022-04-15 11:09:40 PDT
<rdar://problem/91761362>
Attachments
proposed patch. (2.79 KB, patch)
2022-04-15 11:15 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
patch for landing. (2.72 KB, patch)
2022-04-15 12:14 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2022-04-15 11:15:58 PDT
Created attachment 457707 [details] proposed patch.
Saam Barati
Comment 2 2022-04-15 12:03:19 PDT
Comment on attachment 457707 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=457707&action=review > Source/JavaScriptCore/wasm/WasmInstance.h:137 > + double loadF64Global(unsigned i) const { return purifyNaN(bitwise_cast<double>(loadI64Global(i))); } let's just delete this function?
Mark Lam
Comment 3 2022-04-15 12:14:59 PDT
Created attachment 457712 [details] patch for landing.
Mark Lam
Comment 4 2022-04-15 12:55:33 PDT
Thanks for the review. Landed in r292920: <http://trac.webkit.org/r292920>.
Note You need to log in before you can comment on or make changes to this bug.