Bug 239387

Summary:

[GStreamer] REGRESSION(r285586): we never end the playback of some videos

Product:

WebKit

Reporter:

Yacine Bandou <bandou.yacine>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboya, calvaris, eocanha, olivier.blin, pnormand, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-

Yacine Bandou

Reported 2022-04-15 08:52:01 PDT

Since https://commits.webkit.org/r285586 we ignore the EOS message with some videos like this one: https://www.tv5mondeplus.com/bumpers/tv5_bumper.mp4

Attachments
Patch (2.76 KB, patch) 2022-04-15 09:13 PDT, Yacine Bandou	no flags	Details Formatted Diff Diff
Patch (34.11 KB, patch) 2022-04-19 09:51 PDT, Yacine Bandou	no flags	Details Formatted Diff Diff
Patch (34.15 KB, patch) 2022-04-20 04:45 PDT, Yacine Bandou	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yacine Bandou

Comment 1 2022-04-15 09:13:08 PDT

Created attachment 457703 [details] Patch

Philippe Normand

Comment 2 2022-04-15 10:39:12 PDT

Comment on attachment 457703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457703&action=review > Source/WebCore/ChangeLog:3 > + [GStreamer] REGRESSION(r285586): we never end the playback of some videos That seems bad :( I wonder how this wasn't detected earlier with layout tests > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1787 > + GRefPtr<GstPad> SinkPad = adoptGRef(gst_element_get_static_pad(m_videoSink.get(), "sink")); auto sinkPad = ... local variables should not begin with a capital letter > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1792 > + GRefPtr<GstPad> SinkPad = adoptGRef(gst_element_get_static_pad(m_audioSink.get(), "sink")); ditto

Yacine Bandou

Comment 3 2022-04-19 06:00:09 PDT

(In reply to Philippe Normand from comment #2) > Comment on attachment 457703 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457703&action=review > > > Source/WebCore/ChangeLog:3 > > + [GStreamer] REGRESSION(r285586): we never end the playback of some videos > > That seems bad :( I wonder how this wasn't detected earlier with layout tests > This issue is seen on some MP4 videos that have an inaccurate duration in the mvhd box.

Yacine Bandou

Comment 4 2022-04-19 09:51:21 PDT

Created attachment 457908 [details] Patch

Philippe Normand

Comment 5 2022-04-20 02:50:32 PDT

Comment on attachment 457908 [details] Patch Thanks for providing a test :)

EWS

Comment 6 2022-04-20 02:51:16 PDT

/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Philippe Normand

Comment 7 2022-04-20 02:56:29 PDT

Comment on attachment 457908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457908&action=review > Source/WebCore/ChangeLog:5 > + https://webkit.org/contributing-code/#changelog-files

Yacine Bandou

Comment 8 2022-04-20 04:45:14 PDT

Created attachment 457976 [details] Patch

EWS

Comment 9 2022-04-20 05:57:58 PDT

Committed r293091 (249802@main): <https://commits.webkit.org/249802@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457976 [details].

Radar WebKit Bug Importer

Comment 10 2022-04-20 05:58:26 PDT

<rdar://problem/92022235>

Note You need to log in before you can comment on or make changes to this bug.