Bug 239372

Summary:

Use the ProcessTerminationReason enum for all the process types

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

WebKit Process Model

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, cdumez, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cdumez: review+, cdumez: commit-queue-

Simon Fraser (smfr)

Reported 2022-04-14 20:15:02 PDT

Use the ProcessTerminationReason enum for all the process types

Attachments
Patch (27.17 KB, patch) 2022-04-14 20:16 PDT, Simon Fraser (smfr)	cdumez: review+ cdumez: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2022-04-14 20:16:48 PDT

Created attachment 457670 [details] Patch

Chris Dumez

Comment 2 2022-04-14 20:23:57 PDT

Comment on attachment 457670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457670&action=review > Source/WebKit/Shared/ProcessTerminationReason.cpp:55 > + ASSERT_NOT_REACHED() ? > Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:429 > + RELEASE_LOG_ERROR(Process, "%p - GPUProcessProxy::gpuProcessExited: reason=%s", this, processTerminationReasonToString(reason)); Needs to be %{public}s or we won't see the reason on production builds. > Source/WebKit/UIProcess/WebProcessPool.cpp:476 > + WEBPROCESSPOOL_RELEASE_LOG(Process, "gpuProcessDidExit: PID=%d, reason=%s", identifier, processTerminationReasonToString(reason)); Needs to be %{public}s or we won't see the reason on production builds.

Simon Fraser (smfr)

Comment 3 2022-04-15 10:24:01 PDT

https://trac.webkit.org/changeset/292912/webkit

Radar WebKit Bug Importer

Comment 4 2022-04-15 10:24:15 PDT

<rdar://problem/91814862>

Alex Christensen

Comment 5 2022-04-15 11:53:10 PDT

Note You need to log in before you can comment on or make changes to this bug.