Bug 239361

Summary: Use WebCoreBuiltinNames when possible
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ashvayka, benjamin, calvaris, cdumez, changseok, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sam, sergio, webkit-bug-importer, youennf, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=239408
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2022-04-14 17:09:08 PDT
Use WebCoreBuiltinNames when possible to avoid unnecessary calls to Identifier::fromString(). This is more efficient.
Attachments
Patch (66.26 KB, patch)
2022-04-14 17:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (66.53 KB, patch)
2022-04-14 17:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-04-14 17:10:24 PDT
Created attachment 457657 [details] Patch
Yusuke Suzuki
Comment 2 2022-04-14 17:20:16 PDT
Comment on attachment 457657 [details] Patch r=me
Chris Dumez
Comment 3 2022-04-14 17:57:45 PDT
Created attachment 457658 [details] Patch
EWS
Comment 4 2022-04-14 22:45:37 PDT
Committed r292899 (249669@main): <https://commits.webkit.org/249669@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457658 [details].
Radar WebKit Bug Importer
Comment 5 2022-04-14 22:46:14 PDT
<rdar://problem/91796246>
Darin Adler
Comment 6 2022-04-15 14:08:31 PDT
Comment on attachment 457658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457658&action=review > Source/WebCore/bindings/js/WebCoreJSClientData.h:211 > +ALWAYS_INLINE WebCoreBuiltinNames& webCoreBuiltinNames(JSC::VM& vm) Why not call this WebCore::builtInNames instead of WebCore::webCoreBuiltinNames?
Note You need to log in before you can comment on or make changes to this bug.