Bug 239344
| Summary: | IGNORE_WARNINGS_BEGIN should not warn about unrecognized warnings | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mcatanzaro, webkit-bug-importer, zdobersek |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | All | ||
Michael Catanzaro
See https://bugs.webkit.org/show_bug.cgi?id=239299#c7, we don't want to warn about unrecognized warnings
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
This is only a problem for GCC, because Clang has __has_warning() which we use to drop attempts to suppress unrecognized warnings, and I'm pretty sure Clang doesn't warn about unrecognized pragmas anyway. (The IGNORE_WARNINGS macros are only implemented for GCC and Clang.)
Michael Catanzaro
https://github.com/WebKit/WebKit/pull/291
EWS
Committed r292934 (249699@main): <https://commits.webkit.org/249699@main>
Reviewed commits have been landed. Closing PR #291 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/91838502>