Bug 239301

Summary: [Xcode] Fix public watchOS workspace build by updating scheme and build settings
Product: WebKit Reporter: Elliott Williams <emw>
Component: New BugsAssignee: Elliott Williams <emw>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ews-watchlist, hi, pangle, repstein, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Elliott Williams
Reported Wednesday, April 13, 2022 9:56:34 PM UTC
[Xcode] Fix public watchOS workspace build by updating scheme and build settings
Attachments
Patch (8.33 KB, patch)
2022-04-13 14:02 PDT, Elliott Williams
no flags
Patch (13.14 KB, patch)
2022-04-13 15:00 PDT, Elliott Williams
no flags
Elliott Williams
Comment 1 Wednesday, April 13, 2022 10:02:30 PM UTC
Radar WebKit Bug Importer
Comment 2 Wednesday, April 13, 2022 10:07:29 PM UTC
Alexey Proskuryakov
Comment 3 Wednesday, April 13, 2022 10:23:14 PM UTC
Comment on attachment 457567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457567&action=review > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:-51 > - <BuildActionEntry Not clear to me what these changes are doing, and the patch lacks a ChangeLog.
Elliott Williams
Comment 4 Wednesday, April 13, 2022 11:00:55 PM UTC
Elliott Williams
Comment 5 Wednesday, April 13, 2022 11:01:41 PM UTC
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 457567 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457567&action=review > > > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:-51 > > - <BuildActionEntry > > Not clear to me what these changes are doing, and the patch lacks a > ChangeLog. Bad patch, sorry about that. Let me know if there's anything else I can clarify wrt the scheme changes.
Alexey Proskuryakov
Comment 6 Wednesday, April 13, 2022 11:23:59 PM UTC
Comment on attachment 457568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457568&action=review > ChangeLog:19 > + - Remove MiniBrowser from the "All Source" scheme, as it's part of "All > + Tools". "All Tools" probably shouldn't be built for embedded This seems controversial. Engineers use MiniBrowser for testing during iteration, so there should be a one-step way to build WebKit and MiniBrowser at once.
Elliott Williams
Comment 7 Thursday, April 14, 2022 12:40:42 AM UTC
(In reply to Alexey Proskuryakov from comment #6) > Comment on attachment 457568 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457568&action=review > > > ChangeLog:19 > > + - Remove MiniBrowser from the "All Source" scheme, as it's part of "All > > + Tools". "All Tools" probably shouldn't be built for embedded > > This seems controversial. Engineers use MiniBrowser for testing during > iteration, so there should be a one-step way to build WebKit and MiniBrowser > at once. The way you'd do that is by building the MiniBrowser scheme, which will build the stack up to MiniBrowser, including WebKit. And if an engineer wanted to build the entire repo (like EWS does), they'd build "All Modules", which is intended to be equivalent to running `make` from the top-level directory.
EWS
Comment 8 Thursday, April 14, 2022 1:17:05 AM UTC
Committed r292845 (249618@main): <https://commits.webkit.org/249618@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457568 [details].
Note You need to log in before you can comment on or make changes to this bug.