Bug 23928

Summary: Fix run-webkit-tests to skip some dirs when new features are turned off
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Enhancement CC: gsherloc
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 23359    
Attachments:
Description Flags
Patch, changelog aroben: review+

Simon Fraser (smfr)
Reported 2009-02-12 10:30:24 PST
It should be possible for run-webkit-tests to run additional tests to test features that are inside of #ifdefs, without the user having to specify additional directories manually. As is done for SVG, this can be done by using 'nm' to detect if the feature is turned on (by looking for a unique symbol), and then looking for specific test directories.
Attachments
Patch, changelog (3.47 KB, patch)
2009-02-12 11:41 PST, Simon Fraser (smfr) 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-02-12 11:41:59 PST
Created attachment 27615 [details] Patch, changelog
Adam Roben (:aroben)
Comment 2 2009-02-12 13:04:00 PST
Comment on attachment 27615 [details] Patch, changelog > +if (!checkWebCoreAcceleratedCompositingSupport(0)) { > + $ignoredDirectories{'compositing'} = 1; > +} I guess this is the style already used by SVG/WML, but I think something like this would be clearer: if (!checkWebCoreAcceleratedCompositingSupport({required => 0})) { r=me
Simon Fraser (smfr)
Comment 3 2009-02-12 14:30:57 PST
http://trac.webkit.org/changeset/40927
Note You need to log in before you can comment on or make changes to this bug.