Bug 23920

Summary:

build script doesn't respect setting installation prefix

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKit Misc.

Assignee:

Gustavo Noronha (kov) <gustavo>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Gtk

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed fix	aroben: review+

Description Gustavo Noronha (kov) 2009-02-12 07:34:29 PST

The script used to build WebKit expects a WebKitInstallationPrefix environment variable to exist, which should be used to set the installation prefix for autotools builds. The setting is currently being ignored, though.

Comment 1 Gustavo Noronha (kov) 2009-02-12 07:36:29 PST

Created attachment 27602 [details]
proposed fix

Comment 2 Adam Roben (:aroben) 2009-02-12 07:38:33 PST

Comment on attachment 27602 [details]
proposed fix

> +    push @buildArgs, "--prefix=" . $prefix if(defined($prefix));

We normally leave out the parentheses around the condition in these postfix ifs:

push @buildArgs, "--prefix=" . $prefix if defined($prefix);

r=me

Comment 3 Gustavo Noronha (kov) 2009-02-16 19:15:30 PST

Landed in r41033.