Bug 23920

Summary:

build script doesn't respect setting installation prefix

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKit Misc.

Assignee:

Gustavo Noronha (kov) <gustavo>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Gtk

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed fix	aroben: review+

Gustavo Noronha (kov)

Reported 2009-02-12 07:34:29 PST

The script used to build WebKit expects a WebKitInstallationPrefix environment variable to exist, which should be used to set the installation prefix for autotools builds. The setting is currently being ignored, though.

Attachments
proposed fix (1.47 KB, patch) 2009-02-12 07:36 PST, Gustavo Noronha (kov)	aroben: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gustavo Noronha (kov)

Comment 1 2009-02-12 07:36:29 PST

Created attachment 27602 [details] proposed fix

Adam Roben (:aroben)

Comment 2 2009-02-12 07:38:33 PST

Comment on attachment 27602 [details] proposed fix > + push @buildArgs, "--prefix=" . $prefix if(defined($prefix)); We normally leave out the parentheses around the condition in these postfix ifs: push @buildArgs, "--prefix=" . $prefix if defined($prefix); r=me

Gustavo Noronha (kov)

Comment 3 2009-02-16 19:15:30 PST

Landed in r41033.

Note You need to log in before you can comment on or make changes to this bug.