Bug 239131

Summary: Add logging for persistent notification event handler failure
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, nham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2022-04-12 09:56:32 PDT
Add logging for persistent notification event handler failure
Attachments
Patch (2.15 KB, patch)
2022-04-12 10:54 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2022-04-14 08:20 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-04-12 10:54:22 PDT
Created attachment 457347 [details] Patch
Chris Dumez
Comment 2 2022-04-14 07:20:39 PDT
Comment on attachment 457347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457347&action=review > Source/WebCore/workers/service/server/SWServer.cpp:1376 > + RELEASE_LOG_ERROR_IF(succeeded, ServiceWorker, "Service Worker notification event handler did not succeed"); Shouldn't that be !succeeded ?
youenn fablet
Comment 3 2022-04-14 08:20:03 PDT
(In reply to Chris Dumez from comment #2) > Comment on attachment 457347 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457347&action=review > > > Source/WebCore/workers/service/server/SWServer.cpp:1376 > > + RELEASE_LOG_ERROR_IF(succeeded, ServiceWorker, "Service Worker notification event handler did not succeed"); > > Shouldn't that be !succeeded ? Indeed, fixed!
youenn fablet
Comment 4 2022-04-14 08:20:16 PDT
Created attachment 457632 [details] Patch
EWS
Comment 5 2022-04-14 09:25:13 PDT
Committed r292872 (249643@main): <https://commits.webkit.org/249643@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457632 [details].
Radar WebKit Bug Importer
Comment 6 2022-04-14 09:26:14 PDT
<rdar://problem/91758050>
Note You need to log in before you can comment on or make changes to this bug.