Summary: | REGRESSION (r292696): lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string is a constant failure | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Karl Rackler <rackler> | ||||
Component: | New Bugs | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, cdumez, darin, ggaren, jbedard, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Karl Rackler
2022-04-11 14:21:40 PDT
Created attachment 457287 [details]
Patch
Committed r292750 (249534@main): <https://commits.webkit.org/249534@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457287 [details]. Comment on attachment 457287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457287&action=review > Tools/ChangeLog:9 > + Revert change to aNullString made in r292696 as the the following test relies on this String being empty: > + lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string Someone named an empty string "aNullString"! Great way to set a trap for Chris. We also have "anEmptyString" right below. Which is now identical to aNullString. (In reply to Alexey Proskuryakov from comment #5) > We also have "anEmptyString" right below. Which is now identical to > aNullString. Yes, aNullString and anEmptyString are identical now and historically (before I tried to fix this non-sense recently and failed because I didn't realize this python test somehow relies on these). |