Summary: | [Flatpak] clangd wrapper improvements | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | Tools / Tests | Assignee: | Philippe Normand <pnormand> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, bugs-noreply, mrobinson, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2022-04-09 09:00:31 PDT
Created attachment 457166 [details]
Patch
I wonder also, why not pass --enable-config directly to clangd from the wrapper? (In reply to Philippe Normand from comment #2) > I wonder also, why not pass --enable-config directly to clangd from the > wrapper? Maybe to avoid arbitrary user configurations breaking how clangd works? Imagine an user's ~/.clangd file adding -std=c++11 and breaking things. (In reply to Adrian Perez from comment #3) > (In reply to Philippe Normand from comment #2) > > I wonder also, why not pass --enable-config directly to clangd from the > > wrapper? > > Maybe to avoid arbitrary user configurations breaking how clangd works? > Imagine an user's ~/.clangd file adding -std=c++11 and breaking things. The doc explicitly mentions this option, that's why i'm asking. https://trac.webkit.org/wiki/WebKitEnablingFlatpakClangd Committed r292687 (249479@main): <https://commits.webkit.org/249479@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457166 [details]. |