Bug 239032

Summary:

[Flatpak] clangd wrapper improvements

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Tools / Tests

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, bugs-noreply, mrobinson, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Philippe Normand

Reported 2022-04-09 09:00:31 PDT

Attachments
Patch (3.22 KB, patch) 2022-04-09 09:06 PDT, Philippe Normand	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2022-04-09 09:06:14 PDT

Created attachment 457166 [details] Patch

Philippe Normand

Comment 2 2022-04-09 09:52:46 PDT

I wonder also, why not pass --enable-config directly to clangd from the wrapper?

Adrian Perez

Comment 3 2022-04-09 14:00:28 PDT

(In reply to Philippe Normand from comment #2) > I wonder also, why not pass --enable-config directly to clangd from the > wrapper? Maybe to avoid arbitrary user configurations breaking how clangd works? Imagine an user's ~/.clangd file adding -std=c++11 and breaking things.

Philippe Normand

Comment 4 2022-04-09 14:22:43 PDT

(In reply to Adrian Perez from comment #3) > (In reply to Philippe Normand from comment #2) > > I wonder also, why not pass --enable-config directly to clangd from the > > wrapper? > > Maybe to avoid arbitrary user configurations breaking how clangd works? > Imagine an user's ~/.clangd file adding -std=c++11 and breaking things. The doc explicitly mentions this option, that's why i'm asking. https://trac.webkit.org/wiki/WebKitEnablingFlatpakClangd

EWS

Comment 5 2022-04-10 09:48:27 PDT

Committed r292687 (249479@main): <https://commits.webkit.org/249479@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457166 [details].

Radar WebKit Bug Importer

Comment 6 2022-04-10 09:52:28 PDT

<rdar://problem/91536540>

Note You need to log in before you can comment on or make changes to this bug.