Summary: | [JSC] Use Vector with inline capacity in ObjectPropertyConditionSet creation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2022-04-08 22:56:37 PDT
Created attachment 457151 [details]
Patch
Committed r292682 (249474@main): <https://commits.webkit.org/249474@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457151 [details]. Comment on attachment 457151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457151&action=review > Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.h:59 > + template<typename Vector> > + static ObjectPropertyConditionSet create(Vector&& vector) Once this is a template argument it’s a universal reference, so pretty sure we should be using std::forward below instead of WTFMove. Comment on attachment 457151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457151&action=review >> Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.h:59 >> + static ObjectPropertyConditionSet create(Vector&& vector) > > Once this is a template argument it’s a universal reference, so pretty sure we should be using std::forward below instead of WTFMove. Right! Changed. Committed r292713 (249503@trunk): <https://commits.webkit.org/249503@trunk> |