Bug 239025

Summary: [JSC] Use Vector with inline capacity in ObjectPropertyConditionSet creation
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2022-04-08 22:56:37 PDT
[JSC] Use Vector with inline capacity in ObjectPropertyConditionSet creation
Attachments
Patch (8.23 KB, patch)
2022-04-08 22:58 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2022-04-08 22:58:34 PDT
Created attachment 457151 [details] Patch
EWS
Comment 2 2022-04-09 15:26:32 PDT
Committed r292682 (249474@main): <https://commits.webkit.org/249474@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457151 [details].
Radar WebKit Bug Importer
Comment 3 2022-04-09 15:27:15 PDT
<rdar://problem/91526803>
Darin Adler
Comment 4 2022-04-11 10:26:06 PDT
Comment on attachment 457151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457151&action=review > Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.h:59 > + template<typename Vector> > + static ObjectPropertyConditionSet create(Vector&& vector) Once this is a template argument it’s a universal reference, so pretty sure we should be using std::forward below instead of WTFMove.
Yusuke Suzuki
Comment 5 2022-04-11 13:01:06 PDT
Comment on attachment 457151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457151&action=review >> Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.h:59 >> + static ObjectPropertyConditionSet create(Vector&& vector) > > Once this is a template argument it’s a universal reference, so pretty sure we should be using std::forward below instead of WTFMove. Right! Changed.
Yusuke Suzuki
Comment 6 2022-04-11 13:04:30 PDT
Committed r292713 (249503@trunk): <https://commits.webkit.org/249503@trunk>
Note You need to log in before you can comment on or make changes to this bug.