Bug 239008

Summary: Drop unused pluginReplacementScriptObject
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Plug-insAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, changseok, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2022-04-08 10:53:14 PDT
Drop unused pluginReplacementScriptObject as it is always null.
Attachments
Patch (15.38 KB, patch)
2022-04-08 10:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (15.52 KB, patch)
2022-04-08 12:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-04-08 10:54:55 PDT
Created attachment 457096 [details] Patch
Geoffrey Garen
Comment 2 2022-04-08 12:50:25 PDT
Comment on attachment 457096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457096&action=review r=me > Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:80 > +bool YouTubePluginReplacement::installReplacement(ShadowRoot& root) Return type can be void, I think.
Chris Dumez
Comment 3 2022-04-08 12:52:45 PDT
Created attachment 457112 [details] Patch
EWS
Comment 4 2022-04-08 16:01:53 PDT
Committed r292641 (249461@main): <https://commits.webkit.org/249461@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457112 [details].
Radar WebKit Bug Importer
Comment 5 2022-04-08 16:02:16 PDT
<rdar://problem/91507092>
Note You need to log in before you can comment on or make changes to this bug.