Bug 239004

Summary: [WPE][2.36] Build with a11y disabled fails
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WPE WebKitAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Philippe Normand
Reported 2022-04-08 08:46:58 PDT
../Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp:52:67: error: no member named 'accessibilityBusAddress' in 'WebCore::PlatformDisplay' m_dbusAddress = WebCore::PlatformDisplay::sharedDisplay().accessibilityBusAddress().utf8(); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ 1 error generated.
Attachments
Patch (2.83 KB, patch)
2022-04-08 08:48 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (2.74 KB, patch)
2022-04-08 09:25 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2022-04-08 08:48:48 PDT
Created attachment 457076 [details] Patch
Michael Catanzaro
Comment 2 2022-04-08 09:15:14 PDT
Comment on attachment 457076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=457076&action=review > Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp:50 > XDGDBusProxy::XDGDBusProxy(Type type, bool allowPortals) > : m_type(type) > { > +#if ENABLE(ACCESSIBILITY) > switch (m_type) { > case Type::SessionBus: > m_dbusAddress = g_getenv("DBUS_SESSION_BUS_ADDRESS"); I think you're removing too much here, right? This will break the non-a11y proxy too?
Philippe Normand
Comment 3 2022-04-08 09:25:40 PDT
Created attachment 457084 [details] Patch
EWS
Comment 4 2022-04-08 12:55:49 PDT
Committed r292628 (249448@main): <https://commits.webkit.org/249448@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457084 [details].
Note You need to log in before you can comment on or make changes to this bug.